Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump server to use API types for step, service, and secret #337

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

ecrupper
Copy link
Contributor

No description provided.

@ecrupper ecrupper requested a review from a team as a code owner October 18, 2024 18:44
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (7665967) to head (6ee08d1).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #337      +/-   ##
==========================================
+ Coverage   89.63%   91.30%   +1.67%     
==========================================
  Files          22       22              
  Lines         878     1634     +756     
==========================================
+ Hits          787     1492     +705     
- Misses         55      106      +51     
  Partials       36       36              
Files with missing lines Coverage Δ
vela/admin.go 96.55% <100.00%> (+1.37%) ⬆️
vela/secret.go 94.91% <100.00%> (+2.05%) ⬆️
vela/service.go 94.91% <100.00%> (+2.05%) ⬆️
vela/step.go 94.91% <100.00%> (+2.05%) ⬆️

... and 17 files with indirect coverage changes

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 0d47b45 into main Oct 18, 2024
10 of 11 checks passed
@ecrupper ecrupper deleted the chore/bump-server-4-types branch October 18, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants